docs(ai): add acceptance test guide and skill#19887
Conversation
Add docs/ai/acceptance-tests.md covering how to build dependencies and run acceptance tests locally. Add a run-acceptance-tests skill for AI agents. Refactor op-acceptance-tests/justfile to extract build-deps target and add a lightweight `just test` target for running individual tests with automatic dependency building. Remove git submodule update from local builds to avoid reverting in-progress submodule work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I ran the new just target locally to confirm it work, with mise active: |
wwared
left a comment
wwared
left a comment
There was a problem hiding this comment.
I think it would be good to ensure some just target or workflow still runs git submodule update --init --recursive --single-branch -j 8 because not all PRs change things in the submodules, and remembering to keep them updated can lead to weird test errors similarly to outdated contract or cannon artifacts. It might be enough to add a new just target update-deps (or similar) that does this and mentioning it in the ai doc/skill
Slim down the acceptance test skill to a thin wrapper that @-includes the doc. Add `mise exec --` prefix to all just commands since AI agent shells don't have mise activated. Document mise setup in dev-workflow.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
We don't generally have just targets to do git updates and I think updating submodules belongs with that - it's just done as part of your git workflow. If the submodules aren't up to date, it shows up as the git checkout not being clean so AI should sort that out itself and humans usually can as well. |
3 participants
Summary
docs/ai/acceptance-tests.md— full guide for building deps and running acceptance tests locally.claude/skills/run-acceptance-tests/SKILL.md— actionable skill for AI agentsop-acceptance-tests/justfile:build-depstarget fromacceptance-testjust test *argstarget for running individual tests with automatic dep buildinggit submodule updatefrom local builds (can revert in-progress submodule work)AGENTS.mdanddocs/ai/dev-workflow.mdRUST_JIT_BUILD=1for local runs so op-reth and other Rust binaries build on demandTest plan
RUST_JIT_BUILD=1 cd op-acceptance-tests && just test -run TestUnsafeGapFillAfterSafeReorg ./op-acceptance-tests/tests/sync/elsync/reorg/— passed in ~79sjust acceptance-teststill works for full suitejust acceptance-test baseworks for gated subset🤖 Generated with Claude Code